Implement custom behavior for PartialEq, Eq, PartialOrd, Ord and Hash #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Following up on #44, here is my take on implementing
PartialEq
,Eq
,PartialOrd
,Ord
andHash
. This PR goes beyond the scope of the issue, so all those related traits would be in sync.This is a behavior change that, in practice, makes
FixedBitSet
behave like aBTreeSet<usize>
, whose elements are the items returned byFixedBitSet::ones()
. The change can be breaking for some pieces of code that depended on the old behavior, even if it was undocumented and arguably surprising.For example, using
FixedBitSet
in map will behave differently:Fix #44
Please tell me what you think,
Best regards,