New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Binary and Display traits for FixedBitSet. #39
Conversation
src/lib.rs
Outdated
}; | ||
|
||
for block in self.data.iter().rev() { | ||
display_data = display_data.add(&format!("{:b}", block)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. I'd suggest that we just write this piece by piece instead of creating an intermediate String.
src/lib.rs
Outdated
@@ -356,6 +360,32 @@ impl FixedBitSet | |||
} | |||
} | |||
|
|||
#[cfg(feature = "std")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These don't depend on the std feature and will work fine with core, in fact. That's just a smaller thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should remove it though if it is true. On it.
Looks good |
Cool, thanks! Let's be open to tweaks to the format in the future. Maybe |
Providing some implementation for #34. Need feedback.