Add NEON support #115
Closed
Add NEON support #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There should be support for running on ARM via macOS 14 runners. Can you try changing the aarch64 job to run on them and to run the same checks as the x86 jobs? I'm also pretty sure this is also a breaking change since the MSRV for aarch64 is 1.59, up from the current MSRV of 1.56. |
|
Hold on, I added an additional job but perhaps that's a little excessive. |
|
@james7132 You're right about the MSRV, but somehow it passes on 1.56.0 anyway 🤔 |
|
That's certainly odd. Might be a bug with those versions of Rust, or the APIs used here were soft stabilized early. Could you run the benchmarks and do a comparison against master to ensure this is a performance gain? |
This actually does not look like a performance improvement at all, especially for Will have to take a closer look at what's going on. |
|
Looking at the assembly briefly, it doesn't look like rustc is doing any clever auto-vectorization on master. For |
|
@msvbg what were your power settings on your MacBook Pro when running these benchmarks? These numbers don't look right to me given what was changed. |
|
Re-ran the benches with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a continuation of #86, I thought it would be interesting to try to add NEON support to this, given that I haven't written much SIMD code before. It doesn't build continuously on CI yet due to lack of runners, as @james7132 has pointed out, but the tests do pass locally for me on my MBP. Up to you if it's worth merging anyway!