Skip to content

Commit

Permalink
Resolve pull request comments:
Browse files Browse the repository at this point in the history
- constants import changed
- re-export redefined
- contants module reshape to comply with native module details.

Using namespace import and named import for constant required TSLint
config update to allow named imports:
see: palantir/tslint#4524

/cc @43081j

Thanks!
  • Loading branch information
peterblazejewicz authored and PiotrB committed Mar 26, 2020
1 parent ddfca42 commit 4a988f7
Show file tree
Hide file tree
Showing 3 changed files with 47 additions and 43 deletions.
6 changes: 3 additions & 3 deletions types/karma/index.d.ts
Expand Up @@ -14,10 +14,10 @@ import Promise = require('bluebird');
import https = require('https');
import { Appender } from 'log4js';
import { EventEmitter } from 'events';
import constants = require('./lib/constants');
import * as karmaConstants from './lib/constants';
import { VERSION } from './lib/constants';

export { constants };
export const VERSION: typeof constants.VERSION;
export { karmaConstants as constants, VERSION };
/**
* `start` method is deprecated since 0.13. It will be removed in 0.14.
* Please use
Expand Down
72 changes: 33 additions & 39 deletions types/karma/lib/constants.d.ts
@@ -1,42 +1,36 @@
declare const constants: Constants;
/** The current version of karma */
export const VERSION: string;
/** The default port used for the karma server */
export const DEFAULT_PORT: string | number;
/** The default hostname used for the karma server */
export const DEFAULT_HOSTNAME: string;
/** The default listen address used for the karma server */
export const DEFAULT_LISTEN_ADDR: string;
/** The value for disabling logs */
export const LOG_DISABLE: 'OFF';
/** The value for the log `error` level */
export const LOG_ERROR: 'ERROR';
/** The value for the log `warn` level */
export const LOG_WARN: 'WARN';
/** The value for the log `info` level */
export const LOG_INFO: 'INFO';
/** The value for the log `debug` level */
export const LOG_DEBUG: 'DEBUG';
export const LOG_LOG: 'LOG';
/** An array of log levels in descending order, i.e. LOG_DISABLE, LOG_ERROR, LOG_WARN, LOG_LOG, LOG_INFO, and LOG_DEBUG */
export const LOG_PRIORITIES: ['OFF', 'ERROR', 'WARN', 'LOG', 'INFO', 'DEBUG'];

interface Constants {
/** The current version of karma */
VERSION: string;
/** The default port used for the karma server */
DEFAULT_PORT: string | number;
/** The default hostname used for the karma server */
DEFAULT_HOSTNAME: string;
/** The default listen address used for the karma server */
DEFAULT_LISTEN_ADDR: string;
/** The value for disabling logs */
LOG_DISABLE: 'OFF';
/** The value for the log `error` level */
LOG_ERROR: 'ERROR';
/** The value for the log `warn` level */
LOG_WARN: 'WARN';
/** The value for the log `info` level */
LOG_INFO: 'INFO';
/** The value for the log `debug` level */
LOG_DEBUG: 'DEBUG';
LOG_LOG: 'LOG';
/** An array of log levels in descending order, i.e. LOG_DISABLE, LOG_ERROR, LOG_WARN, LOG_LOG, LOG_INFO, and LOG_DEBUG */
LOG_PRIORITIES: ['OFF', 'ERROR', 'WARN', 'LOG', 'INFO', 'DEBUG'];

/** The default color pattern for log output */
COLOR_PATTERN: string;
/** The default pattern for log output without color */
NO_COLOR_PATTERN: string;
/** The default console appender */
CONSOLE_APPENDER: {
/** The default color pattern for log output */
export const COLOR_PATTERN: string;
/** The default pattern for log output without color */
export const NO_COLOR_PATTERN: string;
/** The default console appender */
export const CONSOLE_APPENDER: {
type: string;
layout: {
type: string;
layout: {
type: string;
pattern: string;
};
pattern: string;
};
/** The exit code */
EXIT_CODE: string;
}

export = constants;
};
/** The exit code */
export const EXIT_CODE: string;
12 changes: 11 additions & 1 deletion types/karma/tslint.json
@@ -1 +1,11 @@
{ "extends": "dtslint/dt.json" }
{
"extends": "dtslint/dt.json",
"rules": {
"no-duplicate-imports": [
true,
{
"allow-namespace-imports": true
}
]
}
}

0 comments on commit 4a988f7

Please sign in to comment.