Skip to content

Commit

Permalink
Weird test failures related to puppeteer (mdn#3696)
Browse files Browse the repository at this point in the history
* Weird test failures related to puppeteer

Fixes mdn#3694

* tell dependabot to not upgrade puppeteer 9.x automatically

* specific about 9.1.x
  • Loading branch information
peterbe committed Jun 1, 2021
1 parent a84c31e commit 5a8ae5d
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 5 deletions.
9 changes: 9 additions & 0 deletions .github/dependabot.yml
Expand Up @@ -40,3 +40,12 @@ updates:
prefix: build
prefix-development: chore
include: scope

ignore:
# In https://github.com/mdn/yari/issues/3694 we discovered that
# installing puppeteer 9.1.0 seems to have made the tests flaky
# when jest starts up. See the issue for more detail.
# After this, we can keep an eye on puppeteer to see if the tests
# get better later with new versions.
- dependency-name: "puppeteer"
versions: ["9.1.x"]
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -144,7 +144,7 @@
"prettier": "2.2.1",
"prettier-plugin-packagejson": "^2.2.10",
"pretty-quick": "3.1.0",
"puppeteer": "9.1.0",
"puppeteer": "9.0.0",
"react": "17.0.2",
"react-dom": "17.0.2",
"react-is": "^17.0.2",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Expand Up @@ -15978,10 +15978,10 @@ pupa@^2.0.1:
dependencies:
escape-goat "^2.0.0"

puppeteer@9.1.0:
version "9.1.0"
resolved "https://registry.yarnpkg.com/puppeteer/-/puppeteer-9.1.0.tgz#0530ed1f595088eefd078c8f1f7618d00f216a56"
integrity sha512-+BWwEKYQ9oBTUcDYwfgnVPlHSEYqD4sXsMqQf70vSlTE6YIuXujc7zKgO3FyZNJYVrdrUppy/LLwGF1IRacQMQ==
puppeteer@9.0.0:
version "9.0.0"
resolved "https://registry.yarnpkg.com/puppeteer/-/puppeteer-9.0.0.tgz#b476e17ceb3e33a6667bf682d66dde9898f9c031"
integrity sha512-Avu8SKWQRC1JKNMgfpH7d4KzzHOL/A65jRYrjNU46hxnOYGwqe4zZp/JW8qulaH0Pnbm5qyO3EbSKvqBUlfvkg==
dependencies:
debug "^4.1.0"
devtools-protocol "0.0.869402"
Expand Down

0 comments on commit 5a8ae5d

Please sign in to comment.