Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support github server url for pushing to fork #1318

Merged
merged 3 commits into from Nov 24, 2022
Merged

fix: support github server url for pushing to fork #1318

merged 3 commits into from Nov 24, 2022

Conversation

peter-evans
Copy link
Owner

Follows #1315

@github-actions
Copy link
Contributor

Full test suite slash command (repository admin only)

/test repository=peter-evans/create-pull-request ref=serverurl build=true

@peter-evans
Copy link
Owner Author

peter-evans commented Nov 22, 2022 •
edited by actions-bot

/test repository=peter-evans/create-pull-request ref=serverurl build=true

Command run output

@peter-evans peter-evans changed the title feat: support github server url for pushing to fork fix: support github server url for pushing to fork Nov 24, 2022
@peter-evans
Copy link
Owner Author

I think this change should be considered a fix, not a new feature. I didn't intend for it not to work for self-hosted GitHub server, and I think this is a relatively small change to resolve the issue.

@peter-evans peter-evans merged commit 331d02c into main Nov 24, 2022
@peter-evans peter-evans deleted the serverurl branch November 24, 2022 02:59
fuxingloh pushed a commit to levaintech/keychain that referenced this pull request Jun 19, 2023
@renovate
bump(deps): update peter-evans/create-pull-request action to v4.2.4 (#9)
6220bfe 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[peter-evans/create-pull-request](https://togithub.com/peter-evans/create-pull-request)
| action | patch | `v4.2.1` -> `v4.2.4` |

---

### Release Notes

<details>
<summary>peter-evans/create-pull-request</summary>

###
[`v4.2.4`](https://togithub.com/peter-evans/create-pull-request/releases/tag/v4.2.4):
Create Pull Request v4.2.4

[Compare
Source](https://togithub.com/peter-evans/create-pull-request/compare/v4.2.3...v4.2.4)

⚙️ Patches some recent security vulnerabilities.

##### What's Changed

- Update concepts-guidelines.md by
[@&#8203;chrisbruford](https://togithub.com/chrisbruford) in
[peter-evans/create-pull-request#1610
- 58 dependency updates by
[@&#8203;dependabot](https://togithub.com/dependabot)

##### New Contributors

- [@&#8203;chrisbruford](https://togithub.com/chrisbruford) made their
first contribution in
[peter-evans/create-pull-request#1610

**Full Changelog**:
peter-evans/create-pull-request@v4.2.3...v4.2.4

###
[`v4.2.3`](https://togithub.com/peter-evans/create-pull-request/releases/tag/v4.2.3):
Create Pull Request v4.2.3

[Compare
Source](https://togithub.com/peter-evans/create-pull-request/compare/v4.2.2...v4.2.3)

##### What's Changed

- fix: add check for missing token input by
[@&#8203;peter-evans](https://togithub.com/peter-evans) in
[peter-evans/create-pull-request#1324

**Full Changelog**:
peter-evans/create-pull-request@v4.2.2...v4.2.3

###
[`v4.2.2`](https://togithub.com/peter-evans/create-pull-request/releases/tag/v4.2.2):
Create Pull Request v4.2.2

[Compare
Source](https://togithub.com/peter-evans/create-pull-request/compare/v4.2.1...v4.2.2)

##### What's Changed

- fix: support github server url for pushing to fork by
[@&#8203;peter-evans](https://togithub.com/peter-evans) in
[peter-evans/create-pull-request#1318

##### New Contributors

- [@&#8203;kevinzhu-sa](https://togithub.com/kevinzhu-sa) made their
first contribution in
[peter-evans/create-pull-request#1315

**Full Changelog**:
peter-evans/create-pull-request@v4.2.1...v4.2.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/levaintech/keychain).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMzEuMCIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
aleksandrychev pushed a commit to aleksandrychev/create-pull-request that referenced this pull request Mar 4, 2024
@peter-evans @MildC
@kevinzhu-sa @aleksandrychev
fix: support github server url for pushing to fork (peter-evans#1318)
dfafeeb 
* feat: support github server url for pushing to fork (peter-evans#1315)

Co-authored-by: Kevin Zhu <kevin.zhu@sap.com>

* fix: code formatting

* test: fix tests for getRemoteUrl

Co-authored-by: MildC <kevin.xizhu@gmail.com>
Co-authored-by: Kevin Zhu <kevin.zhu@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peter-evans @MildC