Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support github server url for pushing to fork #1318

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Conversation

peter-evans
Copy link
Owner

Follows #1315

MildC and others added 3 commits November 22, 2022 11:06

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Kevin Zhu <kevin.zhu@sap.com>
@github-actions
Copy link
Contributor

Full test suite slash command (repository admin only)

/test repository=peter-evans/create-pull-request ref=serverurl build=true

@peter-evans
Copy link
Owner Author

peter-evans commented Nov 22, 2022

/test repository=peter-evans/create-pull-request ref=serverurl build=true

Command run output

@peter-evans peter-evans changed the title feat: support github server url for pushing to fork fix: support github server url for pushing to fork Nov 24, 2022
@peter-evans
Copy link
Owner Author

I think this change should be considered a fix, not a new feature. I didn't intend for it not to work for self-hosted GitHub server, and I think this is a relatively small change to resolve the issue.

@peter-evans peter-evans merged commit 331d02c into main Nov 24, 2022
@peter-evans peter-evans deleted the serverurl branch November 24, 2022 02:59
aleksandrychev pushed a commit to aleksandrychev/create-pull-request that referenced this pull request Mar 4, 2024

Verified

This commit was signed with the committer’s verified signature.
aleksandrychev Igor Aleksandrychev
* feat: support github server url for pushing to fork (peter-evans#1315)

Co-authored-by: Kevin Zhu <kevin.zhu@sap.com>

* fix: code formatting

* test: fix tests for getRemoteUrl

Co-authored-by: MildC <kevin.xizhu@gmail.com>
Co-authored-by: Kevin Zhu <kevin.zhu@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants