New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(#1267): use baseUrl for no-proxy determination #1268

Closed

codefish1 wants to merge 1 commit into peter-evans:main from codefish1:bugfix/1267-no-proxy-ignored-for-prs

codefish1 commented Oct 14, 2022 •

edited

Fixes #1267

When a PR is raised, the request.hostname is not set, so can't be found within the noProxyArray.

However the various PR helpers, have the baseUrl parameter set, so use that to determine if we should use the proxy or not.


          bugfix(peter-evans#1267): use baseUrl for no-proxy determination

c571cf6

Author

codefish1 commented Oct 17, 2022

closed in preference of #1269

codefish1 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment