feat: adds support to phpunit 9.3 and php 8.0 #128
Conversation
nunomaduro
changed the title
There was a problem hiding this comment.
@GrahamCampbell already have bootstrapped this pull requests. Here are some notes if someone wants to keep working in this pull request.
|
@GrahamCampbell Thank you for this! Will check this tomorrow. 💜 |
|
Cool. I think I can work through the core of the issues in the next 30 minutes or so. I think dropping PHPUnit less than 9.3 is gonna be the right approach. They also changed the signature of this method:
The current pest code calls passes an array of strings, and phpunit doesn't check the type, which causes issues down the line. That took some head scratching. 😆 Refs: sebastianbergmann/phpunit@c0cf039#diff-168e01c6fa41b415b301f2d245bf8ccb. |
|
EDIT: They were only passing because they had an old version of PHP 8.0. |
|
I think the Windows image is running PHP 8.0.0-alpha2. We will need to wait until alpha3 to see the tests pass on Windows. They pass on Linux now though, however. I will re-trigger a build on 24 Jul 2020, at which point we should have 100% passing tests. |
|
@nunomaduro This is ready for a first review now. :) |
| @@ -87,4 +87,13 @@ public function call(object $target) | |||
| throw $throwable; | |||
| } | |||
| } | |||
|
|
|||
| private static function getUndefinedMethodMessage(object $target, string $methodName): string | |||
There was a problem hiding this comment.
Self note: add tests about this.
| @@ -167,5 +159,13 @@ | |||
| WARN Tests\Visual\Success | |||
| - visual snapshot of test suite on success | |||
|
|
|||
| PASS Tests\Features\Depends | |||
There was a problem hiding this comment.
Self note: understand why this snapshot got different.
|
Hi guys, this is just to remind you about this PR on a new tag unless you are already working on it. Thank you for your work! |
|
We're aware of this PR. It will be released, probably at the start of September. |
|
Going to merge this on master, but there is a few things left before tagging the |
|
Of course, thanks @GrahamCampbell for your work on this. 👍 |
|
🥳 |
This PR:
Note that PHP 8.0.0-beta1 will be released on Aug 06 2020 and PHPUnit 9.3.0 on Aug 07 2020. I think this PR should be released simultaneously with PHPUnit 9.3.