fix: speed up `Position::line_col` for large inputs using SIMD #707

tomtau · 2022-09-10T08:14:29Z

note that this may have extra overhead for small inputs and requires two extra dependencies, hence the faster line_col was put under the optional fast-line-col feature flag.

closes #560

note that this may have extra overhead for small inputs and requires two extra dependencies, hence the faster `line_col` was put under the optional `fast-line-col` feature flag. closes pest-parser#560

tomtau · 2022-09-10T08:24:18Z

@yodalee @huacnlee @matthew-dean @Kilerd I tried to implement the suggestion by @CAD97 : #560 (comment) -- on aarch64, line_col is approximately 50x faster on that large sample input:

default:

line col                time:   [942.44 µs 944.90 µs 947.59 µs]
                        change: [+3537.9% +3547.9% +3558.2%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

with fast-col-line:

line col                time:   [25.940 µs 26.077 µs 26.251 µs]                      
                        change: [-97.266% -97.255% -97.243%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
  4 (4.00%) high mild
  7 (7.00%) high severe

Feel free to open a PR to incrementally track line:col in cursors (e.g. Pair) though if this is not enough.

tomtau

will merge this for the point release

…terator. ref: pest-parser#707, pest-parser#560

…terator. (#754) * Improve line, col calculate performance by use move cursor on Pairs Iterator. ref: #707, #560 * Add benchmark for pair.line_col vs position.line_cole * Fix flat_pairs and pairs.next_back to use position.line_col * Merge line_col method to use `position::line_col`. * Fix `pair.line_col` for supports skiped characters, and add test for rev iter.

fix: speed up Position::line_col for large inputs using SIMD

05e395c

note that this may have extra overhead for small inputs and requires two extra dependencies, hence the faster `line_col` was put under the optional `fast-line-col` feature flag. closes pest-parser#560

tomtau requested review from CAD97 and a team September 10, 2022 08:14

tomtau requested a review from a team as a code owner September 10, 2022 08:14

tomtau commented Sep 12, 2022

View reviewed changes

tomtau merged commit bfbdc4b into pest-parser:master Sep 12, 2022

huacnlee added a commit to huacnlee/pest that referenced this pull request Dec 27, 2022

Improve line, col calculate performance by use move cursor on Pairs I…

6434877

…terator. ref: pest-parser#707, pest-parser#560

huacnlee mentioned this pull request Dec 27, 2022

Improve line, col calculate performance by use move cursor on Pairs Iterator. #754

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: speed up `Position::line_col` for large inputs using SIMD #707

fix: speed up `Position::line_col` for large inputs using SIMD #707

tomtau commented Sep 10, 2022

tomtau commented Sep 10, 2022

tomtau left a comment

fix: speed up Position::line_col for large inputs using SIMD #707

fix: speed up Position::line_col for large inputs using SIMD #707

Conversation

tomtau commented Sep 10, 2022

tomtau commented Sep 10, 2022

tomtau left a comment

Choose a reason for hiding this comment

fix: speed up `Position::line_col` for large inputs using SIMD #707

fix: speed up `Position::line_col` for large inputs using SIMD #707