Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvements #218

Merged
merged 31 commits into from
Jan 9, 2020
Merged

minor improvements #218

merged 31 commits into from
Jan 9, 2020

Conversation

pesser
Copy link
Owner

@pesser pesser commented Dec 13, 2019

  • dont activate ckpt hook on validation batch (to avoid writing checkpoint without having performed a train update)
  • delete results to make sure resources are freed (can avoid running out of memory after a validation pass)
  • fix callbacks being replaced in config causing issues with edeval
  • handle dependencies better
  • wandb integration. closes weights and biases integration #219
  • tensorboardX integration
  • edexplore improvements
  • refactor ProjectManager to run and LogSingleton to log. Added logging of tmux target, pid, pgid. Closes logging in projectmanager #174

@pesser
Copy link
Owner Author

pesser commented Dec 19, 2019

  • fix issue related to pytorch incompatible scipy version and generally reduce required dependencies. installing only required dependencies is now much faster and the full stack of dependencies can be installed with pip install .[full]

@pesser
Copy link
Owner Author

pesser commented Dec 29, 2019

scipy issue is now fixed and pinned to >= 1.4.1. coverage is now pinned to <5.0 (thanks @hperrot #221 (comment))

docs/conf.py Show resolved Hide resolved
@pesser
Copy link
Owner Author

pesser commented Dec 31, 2019

wandb logging with --wandb_logging True.

@pesser
Copy link
Owner Author

pesser commented Jan 3, 2020

did quite a bit of refactoring for ProjectManager and LogSingleton stuff. Both now live in custom_logging.py because they are so interdependent that it doesn't make sense to seperate them. I renamed ProjectManager to simply run and import it in edflow, ie we have edflow.run to get all paths. I think this makes more sense because it really only provides information about the current run and not the whole project. Old names were left for backwards compatibility.

Copy link
Collaborator

@jhaux jhaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment has been fixed in a later commit.

edflow/custom_logging.py Outdated Show resolved Hide resolved
@jhaux
Copy link
Collaborator

jhaux commented Jan 9, 2020

Really nice work! Not so minor in the end! 😄

Copy link
Collaborator

@hperrot hperrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jhaux jhaux merged commit c93e6f6 into master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weights and biases integration logging in projectmanager
4 participants