Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP 2 Support #1183

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

HTTP 2 Support #1183

wants to merge 4 commits into from

Conversation

luneo7
Copy link

@luneo7 luneo7 commented Jul 20, 2020

Picked up from where #514 left, updated the code so it works with the current Jetty version being used. Added tests, a http2 client using Jetty for testing and also support for HTTP 2 clear protocol so people can also leverage HTTP 2 benefits when not using SSL.

People can also test it using JitPack

And after grpc/grpc-java#4738 is merged (grpc/grpc-java#1621) we can also add the possibility of running gRPC on top of HTTP/2

This was referenced Jul 20, 2020
Copy link

@LongWinter LongWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@perwendel
Copy link
Owner

@luneo7 this looks very promising. Thanks for contributing!! I will start reviewing it.
One small thing, it'd be great if you could use the same import order as used in the Spark codebase since the changes makes the diff harder to read. Thanks!

@luneo7
Copy link
Author

luneo7 commented Aug 20, 2020

@perwendel I reverted to the original import order =]

@perwendel
Copy link
Owner

@luneo7 great! :)

@Safiullahkha
Copy link

I want to learn hacking.

@lepe
Copy link

lepe commented Aug 7, 2022

@luneo7 I have applied this PR into the unofficial release-3 (all tests passing). Feel free to give it a try. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants