-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using Storybook's new story parameters (Storybook v5) #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍍 LGTM
Nice! I got very excited about that I can't see any tests for global parameters, it'd be nice to make sure those work as you'd expect. e.g.
Now that global parameters are possible within Percy, is it worth removing the --widths, --rtl and --rtl_regex options from the CLI, as they can be easily expressed with a global |
@BPScott In my one attempt, supplying global params with |
@BPScott Have confirmed that adding global parameters does work. My previous test must have been flawed. |
434bf19
to
678d829
Compare
It'd be nice to also switch this package to use the CC: @djones |
6a5e190
to
8bf188f
Compare
Important: This requires a major version bump when releasing and is dependent on Storybook v5.
Breaking Change: This PR removes addWithPercyOptions and replaces it with Storybook's own story parameters for providing options to Percy.
Options are now provided in a
percy
object in story parameters, either as the 3rd argument to theadd
function, or with aaddParameters
function. i.e.:Storybook's behavior is that adding parameters with the
add
function will be merged into and overwrite clashing parameters provided byaddParameters
.This PR also significantly simplifies installation, removing the need for the long step 3.
Closes #50.
Todo: