Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump axios from 0.18.1 to 0.19.0 #398

Merged
merged 3 commits into from
Oct 18, 2019
Merged

build(deps): bump axios from 0.18.1 to 0.19.0 #398

merged 3 commits into from
Oct 18, 2019

Conversation

kobim
Copy link
Contributor

@kobim kobim commented Oct 12, 2019

Axios 0.19.0 introduced a change which ignored custom configs (axios/axios#1718) such as retry-axios's raxConfig. A fix for this behaviour was recently merged (axios/axios#2207) but there wasn't any release since.

This PR uses a new axios instance instead, thus bypassing the problematic code.
It also fixes a missing default port configuration for the HealthCheck command.

Fixes #226

Copy link
Contributor

@Robdel12 Robdel12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kobim! Thank you for the PR 😃 🏁

@Robdel12 Robdel12 merged commit bc27a96 into percy:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axios 0.19.0 carries breaking changes
2 participants