Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] PMM-7 Updade year in license headers #2968

Closed
wants to merge 2 commits into from

Conversation

artemgavrilov
Copy link
Contributor

@artemgavrilov artemgavrilov requested review from ademidoff and removed request for a team April 22, 2024 15:33
@artemgavrilov artemgavrilov enabled auto-merge (squash) April 22, 2024 15:36
@ademidoff
Copy link
Member

ademidoff commented Apr 22, 2024

@artemgavrilov IMO this is not necessary, since the meaning of the year in copyrights is "Since [year] up to now".

Therefore, the repo files will bear that license until it changes, which is when we should update the year. If there is no intention to change the license, we can leave the year as is.

@artemgavrilov
Copy link
Contributor Author

@artemgavrilov IMO this is not necessary, since the meaning of the year in copyrights is "Since [year] up to now".

Therefore, the repo files will bear that license until it changes, which is when we should update the year.

Hm, I barely remember that we discussed what to do with the year and I thought that we agreed to update it. I am mistaken and we agreed to not touch year, shouldn't in be 2017 then (year when PMM project started)?

@ademidoff
Copy link
Member

ademidoff commented Apr 23, 2024

@artemgavrilov IMO this is not necessary, since the meaning of the year in copyrights is "Since [year] up to now".
Therefore, the repo files will bear that license until it changes, which is when we should update the year.

Hm, I barely remember that we discussed what to do with the year and I thought that we agreed to update it. I am mistaken and we agreed to not touch year, shouldn't in be 2017 then (year when PMM project started)?

In theory we could put 2017 in there, but I don't see much value added.

Anyway, even if there was a theoretical benefit, in my opinion it would just not be worth the effort of:

  • touching 750+ files
  • dealing with conflicts in v3

@artemgavrilov
Copy link
Contributor Author

@artemgavrilov IMO this is not necessary, since the meaning of the year in copyrights is "Since [year] up to now".
Therefore, the repo files will bear that license until it changes, which is when we should update the year.

Hm, I barely remember that we discussed what to do with the year and I thought that we agreed to update it. I am mistaken and we agreed to not touch year, shouldn't in be 2017 then (year when PMM project started)?

In theory we could put 2017 in there, but I don't see much value added.

Anyway, even if there was a theoretical benefit, in my opinion it would just not be worth the effort of:

* touching 750+ files

* dealing with conflicts in v3

Up to PMM team to decide, that's just a proposal.

Regarding approaches, PostgreSQL for example updates headers yearly: postgres/postgres@29275b1

If we will stick with 2023 over time it may look weird.

@artemgavrilov artemgavrilov changed the title PMM-7 Updade year in license headers [Proposal] PMM-7 Updade year in license headers Apr 23, 2024
@artemgavrilov artemgavrilov marked this pull request as draft April 23, 2024 12:30
@artemgavrilov
Copy link
Contributor Author

artemgavrilov commented Apr 23, 2024

@BupycHuk @ademidoff Folks, I'm leaving this up to you to decide what to do. I'm ok with any option.

@ademidoff
Copy link
Member

Closing this for now, will revisit once we stop maintaining v2.

@ademidoff ademidoff closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants