-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add INITIALIZATION_ERROR statue for process initialization failure #2935
base: main
Are you sure you want to change the base?
Add INITIALIZATION_ERROR statue for process initialization failure #2935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just few comments
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2935 +/- ##
==========================================
+ Coverage 43.29% 43.76% +0.47%
==========================================
Files 399 398 -1
Lines 41381 43117 +1736
==========================================
+ Hits 17915 18871 +956
- Misses 21465 22246 +781
+ Partials 2001 2000 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
what
why
If the process fails to start (due to, for instance, a port conflict), the previous design will attempt to retry the process using the same port.
how
In this new commit, the supervisor will confirm the successful initialization of the process. If the initialization fails, it will make up to three attempts to start the process again.