Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-12899 Use module and build cache #2916

Draft
wants to merge 33 commits into
base: v3
Choose a base branch
from
Draft

PMM-12899 Use module and build cache #2916

wants to merge 33 commits into from
+964 −518

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Mar 21, 2024 •
edited

PMM-12899

Link to the Feature Build: SUBMODULES-3595

@codecov Codecov
Copy link

codecov bot commented Mar 21, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v3@47b8e1a). Click here to learn what that means.

❗ Current head d2c4ecb differs from pull request most recent head 0e0bde7. Consider uploading reports for the commit 0e0bde7 to get more accurate results

Additional details and impacted files 
@@          Coverage Diff          @@
##             v3    #2916   +/-   ##
=====================================
  Coverage      ?   43.54%           
=====================================
  Files         ?      364           
  Lines         ?    42606           
  Branches      ?        0           
=====================================
  Hits          ?    18552           
  Misses        ?    22447           
  Partials      ?     1607
Flag Coverage Δ
admin 11.54% <ø> (?)
agent 53.12% <ø> (?)
vmproxy 68.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ademidoff
ademidoff commented Mar 21, 2024
View reviewed changes
.github/workflows/main.yml
SLACK_USERNAME: "PR pipelines bot"
SLACK_ICON_EMOJI: ":chestnut:"
SLACK_USERNAME: "Build bot"
SLACK_ICON_EMOJI: ":octocat:"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I couldn't resist - :octocat: seems to be much more to the point here :)

@ademidoff ademidoff mentioned this pull request Mar 21, 2024
Draft
@ademidoff ademidoff force-pushed the PMM-12899-use-module-and-build-cache branch from 0069c2d to 853be6e Compare March 21, 2024 04:12
@ademidoff
PMM-12641 Fix the dashboard upgrade (#2926)
d57ec55 
* PMM-12641 Fix the dashboard upgrade

This fixes a bug where, due to a wrong ansible formula, PMM would upgrade the dashboards no matter what :)

* PMM-12641 follow up on review
@ademidoff
PMM-12899 prevent grafana from using own GOPATH
5c7821f
@ademidoff
PMM-12899 use a dedicated folder for yarn cache
42a02a9
@ademidoff ademidoff force-pushed the PMM-12899-use-module-and-build-cache branch from 8a0c440 to 42a02a9 Compare April 1, 2024 00:20
@ademidoff
PMM-12899 extract server rpm script
6d0b02b
@ademidoff
Merge branch 'v3' into PMM-12899-use-module-and-build-cache
0a32c59
@ademidoff
PMM-12899 fix server param evaluation
098e894
@ademidoff
Merge branch 'PMM-12899-use-module-and-build-cache' of github.com:per…
c80fe45 
…cona/pmm into PMM-12899-use-module-and-build-cache
@ademidoff
PMM-12899 clean up server RPM specs
aa5729f
@ademidoff
PMM-12899 fix directory permissions
aa5e8b8
@ademidoff
PMM-12899 remove unnecessary macro
ee45fd6
@ademidoff
PMM-12899 revert QAN package name
afde65a
@ademidoff
PMM-12899 merge update.sh to build.sh
f28cbcc
@ademidoff
Merge branch 'v3' into PMM-12899-use-module-and-build-cache
66dc390
@ademidoff
PMM-12899 reorganize the script structure
093179a
@ademidoff
PMM-12899 get rid of exit 0 in callee scripts
12fd453
@ademidoff
PMM-12899 clean up pmm-update.spec
9587f21
@ademidoff
PMM-12899 send exec time to the log file
13b4f65
@ademidoff
PMM-12899 remove a redundant directory
6f9eac8
@ademidoff
PMM-12899 add total exec time
3eb50f8
@ademidoff
PMM-12899 reorg some variables
36869b7
@ademidoff ademidoff force-pushed the PMM-12899-use-module-and-build-cache branch from d613558 to bf640ca Compare April 3, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BupycHuk BupycHuk Awaiting requested review from BupycHuk BupycHuk will be requested when the pull request is marked ready for review BupycHuk is a code owner

@talhabinrizwan talhabinrizwan Awaiting requested review from talhabinrizwan talhabinrizwan will be requested when the pull request is marked ready for review talhabinrizwan is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ademidoff