PMM-10231 Service Params Source #1110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1110 +/- ##
==========================================
- Coverage 43.32% 43.23% -0.09%
==========================================
Files 349 349
Lines 40777 40905 +128
==========================================
+ Hits 17665 17685 +20
- Misses 21586 21690 +104
- Partials 1526 1530 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pkadej
requested review from
BupycHuk,
artemgavrilov,
michal-kralik and
a team
as code owners
pkadej
changed the title
BupycHuk
requested changes
Oct 22, 2022
|
Feel free to merge without waiting for my approval, just make sure that it was QA-ed |
| @@ -57,7 +57,7 @@ type AddExternalCommand struct { | |||
| RunsOnNodeID string `name:"agent-node-id" help:"Node ID where agent runs (default is autodetected)"` | |||
| Username string `help:"External username"` | |||
| Password string `help:"External password"` | |||
| CredentialsSource string `type:"existingfile" help:"Credentials provider"` | |||
| ServiceParamsSource string `help:"Path to file with service parameters"` | |||
There was a problem hiding this comment.
Let's please update the help here so it's clear what is expected.
With the current help it's not clear what the file shall contain.
|
This ticket has been converted to draft until Przemyslaw researches PMM-10909 - whether it can replace code in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-10231
Build: SUBMODULES-2719