This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
update prometheus client library #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoqo
force-pushed
the
update-prometheus-client
branch
from
e9190c8
to
574e0d6
Compare
|
@idoqo CI is failning |
1 task
idoqo
force-pushed
the
update-prometheus-client
branch
from
aa4f36d
to
7f46339
Compare
artemgavrilov
approved these changes
Mar 23, 2022
| @@ -55,7 +55,7 @@ func NewMySQLExplainAction(id string, params *agentpb.StartActionRequest_MySQLEx | |||
| if params.TlsFiles != nil && params.TlsFiles.Files != nil { | |||
| err := tlshelpers.RegisterMySQLCerts(params.TlsFiles.Files) | |||
| if err != nil { | |||
| log.Error(err) | |||
| logrus.Error(err) | |||
There was a problem hiding this comment.
Not sure if the move to logrus brings any UX change on binary output front. Let me know if this switch is okay.
There was a problem hiding this comment.
Yeah I don't think it does either. This was the only place we used it and it wasn't customized in any way. Prometheus' common/log used to be a wrapper around logrus and has been deprecated for a while, it just got removed recently (prometheus/common#306)
idoqo
force-pushed
the
update-prometheus-client
branch
from
527d811
to
beb37fa
Compare
|
@idoqo please fix merge conflicts |
Actually, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates prometheus client due to CVE-2022-21698 which causes failure in WhiteSource security checks.
Build: SUBMODULES-2366