Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt-galera-log-explainer: improvments from feedbacks #765

Merged
merged 9 commits into from Feb 14, 2024

Conversation

ylacancellera
Copy link
Contributor

@ylacancellera ylacancellera commented Feb 9, 2024

Don't get scared by +6482 lines, most of it is from adding a regression test (locally generated)
To me commits are short enough, let me know if that's too much.

summary of various changes:

  • "grep -a": because some logs are sent in a binary format, even though it's actually readable.
  • --skip-merge: useful for cases with identical wsrep node names (got one in actual customer case)
  • small refactor of "extractor" sub-logger. It was not using the same params as the general one, it was giving 2 formats of log when using -vv

operators log improvements:

  • auto detection because many people missed --pxc-operator
  • setting pod name as identifier because it make more sense than using filenames
  • enabling a merge mechanism because many customer cases ends up having many pt-k8s-debug-collector with completely different log files when pvc is destroyed. (merge uses podname+deployment+namespace)

Important:

If this format of PR is not ideal let me know.

  • The contributed code is licensed under GPL v2.0
  • Contributor Licence Agreement (CLA) is signed
  • Documentation updated
  • Test suite update

--skip-merge can help for cases where merge won't work: node names
intentionally identical
grep -a enables to read logs even though they use binary format
Merge happen when podname, deployment name and namespace match
"extrator" log was not using the same output format as the rest
beacuse it was initialized before main()
- Fixed formatting in the documentation
- Synced documentation and README.rst
src/go/pt-galera-log-explainer/types/timeline.go Outdated Show resolved Hide resolved
src/go/pt-galera-log-explainer/types/timeline.go Outdated Show resolved Hide resolved
@ylacancellera ylacancellera merged commit 1462c4e into percona:3.x Feb 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants