PMM-9403 Add extra label for replicaset metrics #804
Merged
+7
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BupycHuk
requested review from
ademidoff and
JiriCtvrtka
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -999,8 +999,8 @@ func oplogStatus(ctx context.Context, client *mongo.Client) ([]prometheus.Metric | |||
| return []prometheus.Metric{headMetric, tailMetric}, nil | |||
| } | |||
|
|
|||
| func replSetMetrics(m bson.M) []prometheus.Metric { | |||
| replSetGetStatus, ok := m["replSetGetStatus"].(bson.M) | |||
| func replSetMetrics(d bson.M) []prometheus.Metric { | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
Function 'replSetMetrics' has too many statements (41 > 40) (funlen)
JiriCtvrtka
reviewed
Feb 28, 2024
| @@ -999,8 +999,8 @@ func oplogStatus(ctx context.Context, client *mongo.Client) ([]prometheus.Metric | |||
| return []prometheus.Metric{headMetric, tailMetric}, nil | |||
| } | |||
|
|
|||
| func replSetMetrics(m bson.M) []prometheus.Metric { | |||
| replSetGetStatus, ok := m["replSetGetStatus"].(bson.M) | |||
| func replSetMetrics(d bson.M) []prometheus.Metric { | |||
There was a problem hiding this comment.
Just out of curiosity. Why "d"? Since it is bson.M not bson.D.
There was a problem hiding this comment.
because it's diagnostic data, needed some other variable, because m was reused below for members.
JiriCtvrtka
approved these changes
Feb 28, 2024
|
@ademidoff let's do it in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-9403 (optional, if ticket reported)
FB
Below we provide a basic checklist of things that would make it a good PR:
Once all checks pass and the code is ready for review, please add
pmm-review-exportersteam as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.