Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update REFERENCE.md to include collector.dbstatsfreestorage #791

Merged
merged 5 commits into from
May 27, 2024

Conversation

knuteriksen
Copy link
Contributor

Adds the --collector.dbstatsfreestorage option introduced in v.0.40.0.

I would also like to add a warning somewhere that states the same as the mongodb documentation:

If the instance has a large number of collections or indexes, obtaining free space usage data may cause processing delays

However, I am not sure where that would fit best.

MongoDB themselves recognized the potential impact to production by setting freeStorage to false by default here

Related pr introducing the option


Below we provide a basic checklist of things that would make it a good PR:

  • Make sure to sign the CLA (Contributor License Agreement).
  • Make sure all tests pass.
  • Keep current with the target branch and fix conflicts if necessary.
  • Update jira ticket description if necessary.
  • Attach screenshots and/or console output to the jira ticket to confirm new behavior, if applicable.
  • Leave notes to the reviewers if you need to focus their attention on something specific.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.

To include the --collector.dbstatsfreestorage option introduced in v.0.40.0.
@knuteriksen knuteriksen requested a review from a team as a code owner January 31, 2024 18:50
@knuteriksen knuteriksen requested review from BupycHuk and JiriCtvrtka and removed request for a team January 31, 2024 18:50
@it-percona-cla
Copy link

it-percona-cla commented Jan 31, 2024

CLA assistant check
All committers have signed the CLA.

REFERENCE.md Outdated Show resolved Hide resolved
JiriCtvrtka and others added 3 commits February 12, 2024 10:11
Co-authored-by: Michael Okoko <10512379+idoqo@users.noreply.github.com>
@BupycHuk BupycHuk enabled auto-merge (squash) February 26, 2024 10:05
@BupycHuk BupycHuk disabled auto-merge May 27, 2024 09:45
@BupycHuk BupycHuk merged commit a7985c2 into percona:main May 27, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants