PMM-9586 Added support for histogram metrics #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for histogram metrics - Upgraded all dependencies.
percona-csalguero
requested review from
ShashankSinha252 and
tshcherban
and removed request for
a team
BupycHuk
requested changes
Jul 21, 2022
Comment on lines
+339
to
+355
| // If all the items have the same number of fields, it is a histogram: | ||
| // "histograms": primitive.M{ | ||
| // "classicWorks": primitive.A{ | ||
| // primitive.M{ | ||
| // "count": 0, | ||
| // "lowerBound": 0, | ||
| // }, | ||
| // primitive.M{ | ||
| // "lowerBound": 128, | ||
| // "count": 0, | ||
| // }, | ||
| // primitive.M{ | ||
| // "lowerBound": 256, | ||
| // "count": 0, | ||
| // }, | ||
| // } | ||
| // } |
There was a problem hiding this comment.
I checked some histogram examples and I found out that each primitive.M contains two fields: some key and count. So I think that the key should be used as a label and count as a value.
Co-authored-by: Nurlan Moldomurov <bupychuk1989@gmail.com>
Co-authored-by: Nurlan Moldomurov <bupychuk1989@gmail.com>
tshcherban
approved these changes
Jul 26, 2022
Co-authored-by: Nurlan Moldomurov <bupychuk1989@gmail.com>
…:percona/mongodb_exporter into PMM-9568_mdb_exporter_histograms
|
@BupycHuk |
BupycHuk
reviewed
Jul 28, 2022
| @@ -321,7 +326,8 @@ func extractHistograms(v []interface{}) map[string][]float64 { | |||
| } | |||
|
|
|||
| var value float64 | |||
| var label string | |||
| var label histogramLabel | |||
| var hasCount bool | |||
|
|
|||
| for key, value := range s { | |||
There was a problem hiding this comment.
can we rename value here to something else, there might be collisions between the value inside the loop and outside.
Comment on lines
+237
to
+239
| histogramLabel{key: "lowerBound", value: "0"}: []float64{0}, | ||
| histogramLabel{key: "lowerBound", value: "128"}: []float64{0}, | ||
| histogramLabel{key: "lowerBound", value: "256"}: []float64{0}, |
There was a problem hiding this comment.
let's set different values for a count value to actually test values.
| value string | ||
| } | ||
|
|
||
| func extractHistograms(v []interface{}) map[histogramLabel][]float64 { |
There was a problem hiding this comment.
I think the value of the map should be just a float64, not an array of floats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-9568