Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

PMM-7 - Allowing to replace pmm module #280

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pkadej
Copy link

@pkadej pkadej commented May 6, 2022

PMM-7 - contributor may use forked pmm/API repository

Build: N/A - changes in linter specs

@pkadej pkadej requested a review from BupycHuk as a code owner May 6, 2022 13:27
@it-percona-cla
Copy link

it-percona-cla commented May 6, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ gen1us2k
✅ denisok
❌ pkadej
You have signed the CLA already but the status is still pending? Let us recheck it.

.golangci.yml Show resolved Hide resolved
Co-authored-by: Nurlan Moldomurov <bupychuk1989@gmail.com>
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Base: 46.01% // Head: 46.10% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (c28969a) compared to base (0b507e1).
Patch has no changes to coverable lines.

❗ Current head c28969a differs from pull request most recent head 67fe30f. Consider uploading reports for the commit 67fe30f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   46.01%   46.10%   +0.09%     
==========================================
  Files          29       29              
  Lines        3199     3199              
==========================================
+ Hits         1472     1475       +3     
+ Misses       1560     1557       -3     
  Partials      167      167              
Flag Coverage Δ
crosscover 46.10% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
service/k8sclient/k8sclient.go 62.14% <0.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants