feat: add command to render multiple trios in roger
#1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf: switch from tsx to ts-node
Deploying with
|
| Latest commit: |
9c337af
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://315ef768.penrose-72l.pages.dev |
| Branch Preview URL: | https://roger-fast.penrose-72l.pages.dev |
± Registry diff📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. If a row has only one bar instead of four, that means it's not a trio and the bar just shows the total time spent for that example, again rounded up to the nearest 100ms. Data |
|
You can fix the JSON import with this diff: diff --git a/packages/roger/index.ts b/packages/roger/index.ts
index 48303f8b..dc7f6bad 100755
--- a/packages/roger/index.ts
+++ b/packages/roger/index.ts
@@ -22,7 +22,7 @@ import convertHrtime from "convert-hrtime";
import * as fs from "fs";
import { basename, extname, join, resolve } from "path";
import prettier from "prettier";
-// import packageJSON from "./package.json"; // TODO: no supported by node
+import packageJSON from "./package.json" assert { type: "json" };
import { InstanceData } from "./types.js";
import watch from "./watch.js";
@@ -255,7 +255,7 @@ const orderTrio = (unordered: string[]): string[] => {
yargs(hideBin(process.argv))
.scriptName("roger")
// .description("Command-line interface for Penrose.")
- // .version(packageJSON.version) // TODO: not supported by node
+ .version(packageJSON.version)
.command(
"trio [trio..]",
"Generate a diagram from a Penrose trio.",
diff --git a/packages/roger/tsconfig.json b/packages/roger/tsconfig.json
index 5619f878..246bfc65 100644
--- a/packages/roger/tsconfig.json
+++ b/packages/roger/tsconfig.json
@@ -1,6 +1,7 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
+ "module": "ESNext",
"noEmit": true,
"noImplicitThis": true,
"resolveJsonModule": true,But did you just mean you don't want to do this right now because it causes the following warning? |
samestep
approved these changes
Jun 8, 2023
Co-authored-by: Sam Estep <sam@samestep.com>
Yep precisely to avoid printing out the warnings |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1439.
This PR contains 2 strategies to mitigate the
rogerstartup time, which is mostly caused by the node runtime.tsxtots-node --esm --swcbecause we observed a 40% speedup when usingts-node. This will hopefully reduce the cost of a singlerogerrun.roger trios [trios..] -o <output-path>to support batch-rendering multiple trios. This command expects a list of.trio.jsonfiles (the extension is necessary for accurate guessing of the output svg file) and render them to<output-path.A small thing:
ts-nodeprints out a warning for ourpackage.jsonimport for version printing (see issue). This is a Node problem, but I've disabledroger --versionfor now to avoid the noisy output.Examples with steps to reproduce them
In
packages/examples, runroger trios **/*.trio.json -o outto render all the trios!Checklist