Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added live preview from dynajoe/vscode-pegjs-live #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

QaDeS
Copy link

@QaDeS QaDeS commented Aug 27, 2023

No description provided.

@hildjj
Copy link
Contributor

hildjj commented Aug 27, 2023

I would want @dynajoe to sign off on this before I even start looking at it. vscode-pegjs-live does not have a LICENSE file.

@QaDeS
Copy link
Author

QaDeS commented Aug 28, 2023

His packag.json states MIT license, but I'm all in with getting him on board. Just needed this live functionality for Peggy, so sharing the integration was quite an afterthought.
Not too experienced with this corner of GitHub...will he be informed automatically by the mention, or should I get in contact separately?

@hildjj
Copy link
Contributor

hildjj commented Aug 28, 2023

The @ mention should have notified. Give them a few days.

@hildjj
Copy link
Contributor

hildjj commented Feb 7, 2024

Seeing no comment from @dynajoe, we're going to go ahead. Here are a list of things that need to get fixed, which I'm happy to do if you don't have time:

  • Rebase on top of Update #48, which I'm about to land. This will cause a few issues and fix a few issues.
  • Several of the references to NodeJS.Timer need to be NodeJS.Timeout.
  • Ensure lint is clean. Probably means adding at least one more ignore to memFs.
  • Look at debounceExecution and see if we need two debounce implementations.
  • Add copyright notice to preview.ts
  • Move CHANGELOG to same format as peggy (I'll do this one for sure)
  • Add more info to README on how live preview works. At least talk about right-clicking, and maybe cmd-shift-p to launch
  • Add screenshot of preview to README

@hildjj
Copy link
Contributor

hildjj commented Feb 13, 2024

@QaDeS this is next on my priority list. Do you want to make the changes, give me access to push to your main branch, or have me start a new PR?

@QaDeS
Copy link
Author

QaDeS commented Feb 14, 2024

@hildjj I added you to my repo. Alas, I'm pretty busy with a new job and life currently, trying to stay open for possibly upcoming questions, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants