Upgrade vulnerable npm packages (round 2) #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get rid of CVE-s I've updated dateformat (peerigon#34) and mocha. Both of them are upgraded to the latest version that gets rid of the security issues AND doesn't break the unit tests.
Upgrade vulnerable npm packages
|
Thanks for the new PR @gagyibenedek! I opened #38 because of the merge conflicts, the lockfile is also still version 1 for us. I'll see that I can get this reviewed and we'll quote you in the release notes. I'll keep you posted. Thanks a ton! |
|
Oh shoot, thanks for cleaning up after me. I guess that's why one shouldn't open PR-s after midnight. |
|
To be fair it was @leomelzer 's changes made after your PR that introduced the conflicts 😛 Yes thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get rid of CVE-s I've updated dateformat (#34), mkdirp and mocha. Both of them are upgraded to the latest version that gets rid of the security issues AND doesn't break the unit tests.
(The earlier version of this PR, #35, is going to be abandoned).