fix: Dont count xunit failures as errors #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per http://reflex.gforge.inria.fr/xunit.html#xunitReport a failure and an error are different concepts and must be counted as such. Some parsers will fail if the number of expected tests do not add up. Related change in repo from which this was copied: mochajs/mocha#2475
|
@matthaias @jhnns Any thoughts here? |
|
Thank you for giving notice 👍 |
leomelzer
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
As this is in mocha for a while now I'd propose to land it here, too: https://github.com/mochajs/mocha/blob/master/lib/reporters/xunit.js#L95-L97
Thanks for the PR!
leomelzer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per http://reflex.gforge.inria.fr/xunit.html#xunitReport a failure and an error are different concepts and must be counted as such. Some parsers will fail if the number of expected tests do not add up.
Related change in repo from which this was copied: mochajs/mocha#2475