Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update packages to resolve CVE issues #38

Merged
merged 5 commits into from Nov 24, 2021
Merged

fix: Update packages to resolve CVE issues #38

merged 5 commits into from Nov 24, 2021

Conversation

leomelzer
Copy link
Member

@leomelzer leomelzer commented Nov 24, 2021

Closes #34

This PR resolves the CVEs as well as avoids issues with ESM by upgrading to the most recent CJS version of dateformat.

Also fix smaller issues with the test setup.

I'd propose to release this as 2.0.0 as we previously didn't have an engines section setup for the module. This requires node >= 12.0.0 now (due to mocha update).

Any doubts?

@gagyibenedek
Copy link
Contributor

LGTM!

@leomelzer leomelzer merged commit 9e6d14e into master Nov 24, 2021
@leomelzer leomelzer deleted the 34/fix-cves branch November 24, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm vulnerability found on dateformat dependency
3 participants