OTA update check: inform about uncommon version mismatch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debug message for version mismatch
debug message for version mismatch
debug message for version mismatch
fixed typo
|
Hey @andreasbrett sorry I didn't reply before but only now I notice your PR! I see real value in your proposal, but I would recommend doing it against the base https://github.com/Koenkk/zigbee-herdsman-converters instead of my fork as this is specific for the current Ledvance OTA update support work only. |
pedrolamas
pushed a commit
that referenced
this pull request
Mar 11, 2020
* Master.support namron.2020.02.27 (#1) * Support Namron ZigBee 4 channel switch K8, model 4512703 Supports on/off and dimming on 4 endpoints * Allow dimmer buttons to dim all the way down to 0 and up to 255 * Remove extra spaces to make ESlint happy * Support Namron ZigBee 1 channel switch K4, model 4512702. Have separate buttons for on/off and dim up/down. * Support Namron ZigBee 1 channel switch K4, model 4512702. It has separate buttons for on/off and dim up/down. * Remove some spaces * Update devices.js * Update fromZigbee.js * Update fromZigbee.js * Update fromZigbee.js * Remove some previously added converters which is no more in use * Update fromZigbee.js * Update devices.js * Update devices.js Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
pedrolamas
pushed a commit
that referenced
this pull request
Oct 4, 2020
* Add "discovery" mode for Xiaomi ZNCLDJ12LM (#1) * Add "discovery" mode for Xiaomi ZNCLDJ12LM Add "discovery" mode for Xiaomi ZNCLDJ12LM to calibrate end points * Add "discovery" mode for Xiaomi ZNCLDJ12LM Add "discovery" mode for Xiaomi ZNCLDJ12LM to calibrate end points * Remove tabs * Update toZigbee.js * Update devices.js * Update toZigbee.js * Update devices.js * Update fromZigbee.js * Update fromZigbee.js * Update toZigbee.js * Update toZigbee.js * Update toZigbee.js Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added debug message for cases where device firmware is newer than the latest version online. This should not happen but might be a helpful log message when version numbers were incorrectly interpreted or a manufacturer changed up the numbering scheme.
See Koenkk#1000 (comment)