Skip to content

chore: Bump thiserror from 1.0.58 to 1.0.59 (#280) #698

chore: Bump thiserror from 1.0.58 to 1.0.59 (#280)

chore: Bump thiserror from 1.0.58 to 1.0.59 (#280) #698

Triggered via push April 22, 2024 08:45
Status Success
Total duration 3m 16s
Artifacts

ci.yaml

on: push
Cargo Sort check
16s
Cargo Sort check
Cargo Clippy Check
28s
Cargo Clippy Check
Matrix: Build and Test
Fit to window
Zoom out
Zoom in

Annotations

33 warnings
deref which would be done by auto-deref: fatigue/src/main.rs#L99
warning: deref which would be done by auto-deref --> fatigue/src/main.rs:99:47 | 99 | output_formatter.update_result_status(&*rx.borrow()); | ^^^^^^^^^^^^^ help: try: `&rx.borrow()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default
usage of an `Arc` that is not `Send` and `Sync`: fatigue/src/main.rs#L77
warning: usage of an `Arc` that is not `Send` and `Sync` --> fatigue/src/main.rs:77:28 | 77 | let output_formatter = Arc::new(get_output_formatter()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `Arc<Box<dyn OutputFormatter>>` is not `Send` and `Sync` as: = note: - the trait `Send` is not implemented for `Box<dyn OutputFormatter>` = note: - the trait `Sync` is not implemented for `Box<dyn OutputFormatter>` = help: consider using an `Rc` instead. `Arc` does not provide benefits for non `Send` and `Sync` types = note: if you intend to use `Arc` with `Send` and `Sync` traits = note: wrap the inner type with a `Mutex` or implement `Send` and `Sync` for `Box<dyn OutputFormatter>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default
redundant closure: libfatigue/src/context/mod.rs#L158
warning: redundant closure --> libfatigue/src/context/mod.rs:158:18 | 158 | .map(|a| StaticContextTracker::new(a)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `StaticContextTracker::new` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default
returning the result of a `let` binding from a block: libfatigue/src/context/actions/json.rs#L43
warning: returning the result of a `let` binding from a block --> libfatigue/src/context/actions/json.rs:43:21 | 42 | let res = serde_json::from_str(raw.as_str())?; | ---------------------------------------------- unnecessary `let` binding 43 | res | ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 42 ~ 43 ~ serde_json::from_str(raw.as_str())? |
useless conversion to the same type: `std::str::Lines<'_>`: libfatigue/src/actions/request.rs#L34
warning: useless conversion to the same type: `std::str::Lines<'_>` --> libfatigue/src/actions/request.rs:34:43 | 34 | let rendered_path_lines: Vec<_> = rendered_path | ___________________________________________^ 35 | | .lines() 36 | | .into_iter() | |________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default help: consider removing `.into_iter()` | 34 ~ let rendered_path_lines: Vec<_> = rendered_path 35 + .lines() |
Cargo Sort check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/install@v0.1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Cargo Sort check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/install@v0.1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Cargo Sort check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Cargo Sort check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Cargo Sort check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Cargo Sort check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Cargo Clippy Check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Cargo Clippy Check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Cargo Clippy Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Cargo Clippy Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Cargo Clippy Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Cargo Clippy Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and Test (ubuntu-latest, stable)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build and Test (ubuntu-latest, stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build and Test (ubuntu-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and Test (ubuntu-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and Test (ubuntu-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and Test (ubuntu-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and Test (ubuntu-latest, stable)
virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
Build and Test (ubuntu-latest, stable)
virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
Build and Test (windows-latest, stable)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build and Test (windows-latest, stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build and Test (windows-latest, stable)
virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
Build and Test (windows-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and Test (windows-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and Test (windows-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and Test (windows-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and Test (windows-latest, stable)
virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`