Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Modify pytest kwargs #51

Merged
merged 2 commits into from Apr 20, 2018
Merged

DEV: Modify pytest kwargs #51

merged 2 commits into from Apr 20, 2018

Conversation

teddyrendahl
Copy link
Contributor

Description

Updated my version of pytest and ran into this issue pytest-dev/pytest#3413.

The TL;DR is a combination of the argument parsing in pytest and the default argparse library does not like when one command line argument is just a shortened version of another. In pytest=3.5 it appears they added arguments that start with show so when ever I tried to use my argument I received

$ py.test --show
usage: py.test [options] [file_or_dir] [file_or_dir] [...]
py.test: error: ambiguous option: --show could match --showlocals, --show-capture

I have renamed show to show-ui and now there are no conflicts! Also, after #49 there is no need to have command line arguments to configure the logging setup. These have been deprecated.

teddyrendahl added 2 commits April 20, 2018 09:29
Logs are dumped to file at DEBUG level by #49
Show conflicts with newer command line arguments added to pytest. Leading to an
error message complaining about ambiguous options.
@codecov-io
Copy link

codecov-io commented Apr 20, 2018

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files           5        5           
  Lines         391      391           
=======================================
  Hits          374      374           
  Misses         17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 350d523...64d21b5. Read the comment docs.

@teddyrendahl teddyrendahl merged commit e924199 into pcdshub:master Apr 20, 2018
@teddyrendahl teddyrendahl deleted the pytest_kwargs branch April 20, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants