#78 output error when failing config is detected #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthierba
requested changes
Feb 2, 2022
| Log.Warning($"Config folder contains file {file}. Probably MSMDSRV.exe was unable to launch because of an invalid config. Deletion of the config files will skipped to allow inspection."); | ||
| } | ||
|
|
||
| if (Log.IsEnabled(LogEventLevel.Debug)) | ||
| { | ||
| Log.Debug("Deleting file {Path}", file); |
There was a problem hiding this comment.
This is problematic since in the case of failedConfigFound == true the tool would be logging "Deleting file ..." even though nothing is getting deleted.
This line already detects whether the msmdsrv process exited unexpectedly:
I'd set the hasFailed marker there, and have the Dispose() honor that.
| foreach (var file in Directory.EnumerateFiles(_tempPath, "*", SearchOption.AllDirectories)) | ||
| if (file.ToLower().Contains("failed")) { | ||
| failedConfigFound = true; | ||
| Log.Warning($"Config folder contains file {file}. Probably MSMDSRV.exe was unable to launch because of an invalid config. Deletion of the config files will skipped to allow inspection."); |
There was a problem hiding this comment.
Serilog doesn't use string interpolation. Instead, it uses semantic logging where parameters are explicitly declared and provided using traditional params object[] syntax.
In this case it would be:
Log.Warning($"Config folder contains file {FailureFilePath}. Probably MSMDSRV.exe was unable to launch because of an invalid config. Deletion of the config files will skipped to allow inspection.", file);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#78 output error when failing config is detected