Update PbixProject.cs #285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added row to indicate new, non default, MaxDepth, Re pbi-tools#284
|
My 1st Commit to a fork of a public open source project in a language I hardly know... |
|
Thanks for the effort, @scottstauffer-fc . Unfortunately, your change only impacts the writing of |
|
I’ll see what my colleague, Todd can do to make this happen – he’s a C# guy.
Hope life is treating you well.
Sad we couldn’t spend more time in Seattle at PASS.
Looking forward to an opportunity to share a drink or meal when next we meet!
Cheers,
Scott
From: Mathias Thierbach ***@***.***>
Sent: Wednesday, May 17, 2023 21:51
To: pbi-tools/pbi-tools ***@***.***>
Cc: Scott Stauffer ***@***.***>; Mention ***@***.***>
Subject: Re: [pbi-tools/pbi-tools] Update PbixProject.cs (PR #285)
Thanks for the effort, @scottstauffer-fc<https://github.com/scottstauffer-fc> . Unfortunately, your change only impacts the writing of .pbixproj.json, not the /Report files. The changes will actually be needed here: https://github.com/pbi-tools/pbi-tools/blob/main/src/PBI-Tools/FileSystem/ProjectFolderExtensions.cs<https://github.com/pbi-tools/pbi-tools/blob/main/src/PBI-Tools/FileSystem/ProjectFolderExtensions.cs>
Best to add test cases to verify the change works correctly (that'll also help me with approving it faster).
—
Reply to this email directly, view it on GitHub<#285 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AW6SW6NPG47AIBCY34K7DXDXGWTDFANCNFSM6AAAAAAYFYIRI4>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added row to indicate new, non default, MaxDepth,
Re #284
I have ABSOLUTELY no idea what I'm doing. It looks right the right place to do this, but I'm NOT a C# dev by any stretch of the imagination.