fix: dynamic messages - pass merchant id from cpnw callback, flush logger #2381
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seavenly
reviewed
May 8, 2024
Seavenly
reviewed
May 20, 2024
Seavenly
reviewed
May 21, 2024
Seavenly
approved these changes
May 23, 2024
danzhaaspaypal
approved these changes
Jun 6, 2024
danzhaaspaypal
approved these changes
Jun 6, 2024
wsbrunson
reviewed
Jun 11, 2024
src/zoid/buttons/component.jsx
Outdated
| const { message, buttonSessionID, currency, merchantID } = props; | ||
|
|
||
| // override with server id if partner does not exist | ||
| getLogger().addTrackingBuilder(() => ({ | ||
| [FPTI_KEY.SELLER_ID]: merchantID?.toString() || serverMerchantId, |
There was a problem hiding this comment.
this already exists in sdk-client: https://github.com/paypal/paypal-sdk-client/blob/main/src/tracking.js#L138
I would consider changing this to
if (serverMerchantId) {
getLogger().addTrackingBuilder(() => ({
[FPTI_KEY.SELLER_ID]: serverMerchantId,
}))
}
There was a problem hiding this comment.
let me get this added
src/zoid/buttons/util.js
Outdated
| @@ -396,7 +396,7 @@ export const getModal: ( | |||
|
|
|||
| return window[namespace].MessagesModal({ | |||
| account: `client-id:${clientID}`, | |||
| merchantId: merchantID?.join(",") || undefined, | |||
| merchantId: merchantID?.join() || undefined, | |||
There was a problem hiding this comment.
did you mean to drop the "," in the join?
There was a problem hiding this comment.
i think by default it makes it comma delimited but i can add it back in for clarity
There was a problem hiding this comment.
There was a problem hiding this comment.
i went ahead and added it back in just in case
There was a problem hiding this comment.
i addressed the comments
wsbrunson
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we are passing merchantID from a callback handled in an internal service. We are also flushing the logger that way on page navigation we can send up logger events
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!