Fix rounding mantissa overflow #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paupino
reviewed
Sep 2, 2022
There was a problem hiding this comment.
Thank you for finding this bug and issuing a fix!
I think this looks good - I have a couple of nits that it'd be good to address first (for my own future sanity reasons!).
One additional thing I think should perhaps be added to this: could you add a couple more benchmarks for these edge cases? I don't think it should make much of a difference, however it'd good to be a little more certain about this. The explicit benchmark we'd want to check is decimal_from_str.
paupino
reviewed
Nov 24, 2022
paupino
reviewed
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #540