Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rand support #517

Merged
merged 2 commits into from
May 28, 2022
Merged

Add rand support #517

merged 2 commits into from
May 28, 2022

Conversation

c410-f3r
Copy link
Contributor

Fix #489 (Don't know why the issue was closed)

Through a feature called rand that is disabled by default

c410-f3r
c410-f3r commented May 27, 2022
View reviewed changes
Cargo.toml Show resolved Hide resolved
paupino
paupino reviewed May 28, 2022
View reviewed changes
src/rand.rs Outdated Show resolved Hide resolved
@paupino paupino enabled auto-merge (squash) May 28, 2022 18:48
@paupino paupino merged commit 4ee19c6 into paupino:master May 28, 2022
@c410-f3r
Copy link
Contributor Author

Thanks @paupino

@lukesneeringer
Copy link
Contributor

lukesneeringer commented May 31, 2022 •
edited

As chance would have it, I need...exactly this for something I'm working on (I'm trying to get decimal support added to ta-rs).

@paupino Would it be possible / reasonable to release a 1.24 with this (and other new features on HEAD in the last couple months) in it?

A huge thank you, by the way!

@paupino
Copy link
Owner

paupino commented May 31, 2022

@lukesneeringer Yep, we can do that! It'll be a smaller release, but sometimes that's just fine too 😄

@paupino
Copy link
Owner

paupino commented May 31, 2022 •
edited

@lukesneeringer Should be released now as 1.24.0!

@lukesneeringer lukesneeringer mentioned this pull request Jun 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paupino paupino paupino left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a rand feature
3 participants
@c410-f3r @lukesneeringer @paupino