Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fsevents to fix prototype pollution attack #704

Closed
wants to merge 1 commit into from

Conversation

@fenichelar
Copy link
Author

A 2.0.4 release with this would be great :)

@coveralls
Copy link

coveralls commented Apr 20, 2018

Coverage Status

Coverage decreased (-0.05%) to 98.5% when pulling fb0136f on fenichelar:master into 925b534 on paulmillr:master.

@es128
Copy link
Collaborator

es128 commented Apr 20, 2018

This is already handled by the caret semver operator, making this PR unnecessary. Just do a fresh install.

@es128 es128 closed this Apr 20, 2018
@fenichelar
Copy link
Author

fenichelar commented Apr 20, 2018

It is best practice to release a new patch version to address a vulnerability because it forces commands like npm update -S to grab the new release without requiring a fresh install. When you have many applications to manage, it is really annoying to do fresh installs all over the place. I understand that this is not actually a security risk, but I think all vulnerabilities should be treated the same. Is there a reason that you seem to be so against making new releases?

@es128
Copy link
Collaborator

es128 commented Apr 20, 2018

My main concern is that I do not yet know the fallout of the node 0.12 breaking change, and forcing fsevents@1.2.0 here makes that a less reconcilable situation for any users affected.

Sorry to cause you annoyance, but you do already have the means to resolve it at your disposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants