Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not filter out symlink paths found under glob patterns #406

Merged
merged 2 commits into from Dec 3, 2015
Merged

Conversation

es128
Copy link
Collaborator

@es128 es128 commented Dec 2, 2015

es128 added a commit that referenced this pull request Dec 3, 2015
Do not filter out symlink paths found under glob patterns
@es128 es128 merged commit 937f389 into master Dec 3, 2015
@es128 es128 deleted the fix-293 branch December 3, 2015 19:10
@laggingreflex
Copy link

This still doesn't seem to fix #293. It only works when watching symlink/**/* directly. It still doesn't work when watching folder/**/* and there's a folder/symlink/file change..

@adityavohra7
Copy link

bump. I opened an issue on chokidar-cli which seems to be symptomatic of the problem above.

I'm watching bower_components/**/*.js which contains both regular directories, and symlinks to directories (created via bower link). Changes to the linked directories aren't detected.

@trainerbill
Copy link

+1. I have a modules/ folder with symlinks in it and watching ./modules/*/.js. Using Gulp 4 with latest chokidar. It does not work with matching a pattern in folder/symlink/pattern. If I place the direct file path it works with symlink and if I remove the symlink and copy the directory in /modules folder it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants