Skip to content
This repository has been archived by the owner on Mar 15, 2021. It is now read-only.

Remove global Fabrication.manager reference in Defintion #313

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Remove global Fabrication.manager reference in Defintion #313

wants to merge 8 commits into from

Commits on May 23, 2019

  1. Remove global Fabrication.manager reference in Defintion 

    The Manager can inject this into the Definition class since there's no
apparent public callers outside of the Fabrication gem that would use
this class.
    @bradgessler
    bradgessler committed May 23, 2019
    Configuration menu
    Copy the full SHA
    1780e49 View commit details
    Browse the repository at this point in the history

  2. Remove singleton module from Manager

    @bradgessler
    bradgessler committed May 23, 2019
    Configuration menu
    Copy the full SHA
    d4fc354 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2019

  1. Extract loader into a class

    @bradgessler
    bradgessler committed May 24, 2019
    Configuration menu
    Copy the full SHA
    b16e4fe View commit details
    Browse the repository at this point in the history

  2. Move initialization failure into schematic lookup

    @bradgessler
    bradgessler committed May 24, 2019
    Configuration menu
    Copy the full SHA
    40ed76c View commit details
    Browse the repository at this point in the history

Commits on May 25, 2019

  1. Move Fabricator.schematic to Manager#load_schematic

    @bradgessler
    bradgessler committed May 25, 2019
    Configuration menu
    Copy the full SHA
    08dfb04 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2019

  1. Move Manager#load_schematic to Loader#load_schematic

    @bradgessler
    bradgessler committed May 26, 2019
    Configuration menu
    Copy the full SHA
    b5ac72f View commit details
    Browse the repository at this point in the history

  2. Move @Initializing state from Manager to Loader

    @bradgessler
    bradgessler committed May 26, 2019
    Configuration menu
    Copy the full SHA
    f60bdf0 View commit details
    Browse the repository at this point in the history

  3. Move Loader class into its own file

    @bradgessler
    bradgessler committed May 26, 2019
    Configuration menu
    Copy the full SHA
    6c8ade0 View commit details
    Browse the repository at this point in the history