Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VncConsole): prevent running initialization code more than once (#8373) #8374

Merged
merged 1 commit into from
Dec 8, 2022
Merged

fix(VncConsole): prevent running initialization code more than once (#8373) #8374

merged 1 commit into from
Dec 8, 2022

Commits on Nov 30, 2022

  1. fix(VncConsole): prevent running initialization code more than once (p… 

    …atternfly#8373)

The functions that were on the dependency list of the useEffect hook
got redefined each time the component got updated, resulting
in the component's initialization code, from within the useEffect hook,
to be running more than once.
That was unwanted behavior and the useCallback wrappers should prevent
it.
    @KKoukiou
    KKoukiou committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    bb864dc View commit details
    Browse the repository at this point in the history