DataLis pagination demo #10276
Open
DataLis pagination demo #10276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-10276.surge.sh A11y report: https://patternfly-react-pr-10276-a11y.surge.sh |
kmcfaul
reviewed
Apr 16, 2024
packages/react-core/src/demos/DataList/examples/DataListPagination.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/DataList/examples/DataListPagination.tsx
Outdated
Show resolved
Hide resolved
tlabaj
requested review from
a team and
mmenestr
and removed request for
a team
gitdallas
requested changes
Apr 18, 2024
packages/react-core/src/demos/DataList/examples/DataListPagination.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/DataList/examples/DataListPagination.tsx
Outdated
Show resolved
Hide resolved
thatblindgeye
requested changes
Apr 18, 2024
packages/react-core/src/demos/DataList/examples/DataListPagination.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/DataList/examples/DataListPagination.tsx
Outdated
Show resolved
Hide resolved
implement review comments
|
Thanks you all for reviewing PR. In Github issue, it was about the static pagination. That's why I made it static pagination, not dynamic. |
|
i understand the confusion there, HTML demos are always static in that sense necessarily though. |
gitdallas
reviewed
Apr 19, 2024
packages/react-core/src/demos/DataList/examples/DataListPagination.tsx
Outdated
Show resolved
Hide resolved
ajaypratap003
changed the title
thatblindgeye
approved these changes
Apr 25, 2024
|
Hey folks, |
gitdallas
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10247
DataList pagination demo
Additional issues: