Masthead: add demo that includes horizontal nav

[ajaypratap003]

What: Closes #6826
Masthead: add demo that includes horizontal nav

Additional issues:

[patternfly-build]

Preview: https://patternfly-react-pr-10241.surge.sh

A11y report: https://patternfly-react-pr-10241-a11y.surge.sh

[wise-king-sullyman]

Looks great!

One question I have, I wonder if we would want to remove all of the logic for the search input and the favoriting and everything? It seems like it isn't really the focus of this demo and it seems to take up about half of the file.

[wise-king-sullyman]

🎉

[tlabaj]

@ajaypratap003 this demo was recently added to the v6 branch. Perhaps you could cherry pick that commit, or you could make sure they align.

[ajaypratap003]

@ajaypratap003 this demo was recently added to the v6 branch. Perhaps you could cherry pick that commit, or you could make sure they align.

@tlabaj Can you please share the commit which is related to this PR

[tlabaj]

@ajaypratap003 this demo was recently added to the v6 branch. Perhaps you could cherry pick that commit, or you could make sure they align.

@tlabaj Can you please share the commit which is related to this PR

@ajaypratap003 Nevermind. I was mistaken. it was a Nav example that was added.

[ajaypratap003]

@tlabaj Can you please merge this PR if everything look good.

[andrew-ronaldson]

lgtm, thanks!

[mattnolting]

Nice work! Looks like you need to add toolbar to .pf-v5-c-masthead__content.

[ajaypratap003]

Nice work! Looks like you need to add toolbar to .pf-v5-c-masthead__content.

@mattnolting Sorry, I don't get this point. Can you please describe bit more

[kmcfaul]

lgtm

@mattnolting Can you explain a bit more what your requested change is? The masthead content does contain the toolbar.

[mattnolting]

@kmcfaul @ajaypratap003
From: https://www.patternfly.org/components/masthead/html-demos/horizontal-nav/

[mattnolting]

nav goes inside a toolbar__item with the class pf-m-overflow-container

Current

update

[ajaypratap003]

nav goes inside a toolbar__item with the class pf-m-overflow-container

Current

**update**

nav is already inside toolbar_item. this is the latest commit 525f4a7

[mattnolting]

nav goes inside a toolbar__item with the class pf-m-overflow-container
Current

update

nav is already inside toolbar_item. this is the latest commit 525f4a7

Still can't see these.

This private-user-images.githubusercontent.com page can’t be found