Merge pull request #468 from XmiliaH/fix-467

Fix 467
patriksimek · Aug 28, 2022 · d6379e1 · d6379e1
2 parents 58478a5 + d9a7f3c
commit d6379e1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/setup-sandbox.js b/lib/setup-sandbox.js
@@ -67,7 +67,8 @@ Object.defineProperties(global, {
 	global: {value: global, writable: true, configurable: true, enumerable: true},
 	globalThis: {value: global, writable: true, configurable: true},
 	GLOBAL: {value: global, writable: true, configurable: true},
-	root: {value: global, writable: true, configurable: true}
+	root: {value: global, writable: true, configurable: true},
+	Error: {value: LocalError}
 });
 
 if (!localReflectDefineProperty(global, 'VMError', {

diff --git a/test/vm.js b/test/vm.js
@@ -1070,6 +1070,13 @@ describe('VM', () => {
 			Error.prepareStackTrace = undefined;
 			stack.process
 		`));
+		assert.throws(()=>vm2.run(`(()=>{
+			const OldError = Error;
+			global.Error = {prepareStackTrace: (_, c) => c.map(c => c.getThis()).find(a => a && a.process)};
+			const { stack } = new OldError();
+			global.Error = OldError;
+			return stack.process.mainModule;
+		})()`));
 	});
 
 	it('Node internal prepareStackTrace attack', () => {