(BSR)[API] doc: indicate which version of Python to use #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariedestandau
changed the title
cgaunet
reviewed
Mar 14, 2022
api/README.md
Outdated
| @@ -27,7 +27,7 @@ Spectree: | |||
| Avec `venv` (vous pouvez aussi utiliser `virtualenv` si vous préférez, voire `virtualenvwrapper`): | |||
|
|
|||
| ```shell | |||
| python3.9 -m venv ./venv | |||
| python3.9.7 -m venv ./venv | |||
There was a problem hiding this comment.
On est passés en 3.9.10 récemment 😬
Je pense néanmoins que c'est la bonne chose de spécifier la mineure en tous cas 👍
Est-ce que tu peux mettre en 3.9.10 ?
There was a problem hiding this comment.
Le module qui pose probleme est cassé à partir de la 3.9.8
python/typed_ast#169 (comment)
There was a problem hiding this comment.
je vois que vous ne validez pas, même si la situation n'est pas idéale il me semble qu'il vaut mieux à jour la doc en attendant de trouver une solution, ça évitera peut-être à d'autres de perdre du temps à l'installation
dbaty
reviewed
Mar 23, 2022
mariedestandau
force-pushed
the
bsr-indicate-precise-python-version
branch
from
2fabb9d
to
f50bd96
Compare
dbaty
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lien vers le ticket Jira : pas de tiquet
But de la pull request
Indiquer dans la doc la version de Python pour éviter des problèmes à l'installation
Implémentation