(PC-7917) (Tech) Lingui, extract unicode characteres from translations #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,7 +70,7 @@ export function getBookingLabels(booking: Booking, properties: BookingProperties | |||
| } | |||
| } else if (properties.isPhysical) { | |||
| dateLabel = expirationDatetime | |||
| ? t`À retirer avant le\u00a0` + formatToCompleteFrenchDate(expirationDatetime, false) | |||
| ? t`À retirer avant le` + `\u00a0${formatToCompleteFrenchDate(expirationDatetime, false)}` | |||
There was a problem hiding this comment.
❓comment tu sais si tu les as bien enlevés partout ?
There was a problem hiding this comment.
J'ai fais une recherche sur \u, je les ai tous corrigé sauf 3, voir commentaire lingui/js-lingui#1022 (comment)
marionnousvalentin
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-7917
Checklist
I have:
[PC-XXX] <summary>.(for tech tasks, give the best context about the TODO resolution: what/who/when).
Screenshots
Deploy hard
If native code (ios/android) was modified, after the PR is merged, on the master branch, upgrade the app version (+1 patch):
yarn trigger:testing:deploy