Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Tech): first tutorial second card not displaying text with lingui v3 #849

Closed
wants to merge 1 commit into from

Conversation

kopax-polyconseil
Copy link
Contributor

Fix <SecondCard /> props.text, see lingui/js-lingui#1022 (comment)

Checklist

I have:

  • Made sure the title of my PR follows the convention [PC-XXX] <summary>.
  • Made sure my feature is working on the relevant real / virtual devices.
  • Written unit tests for my feature.
  • Added new reusable components to the AppComponents page and communicate to the team on slack
  • Added a screenshot for UI tickets.
  • Attached a ticket number for any added TODO/FIXME
    (for tech tasks, give the best context about the TODO resolution: what/who/when).

Screenshots

*iOS - [Phone name] *Android - [Phone name] Tablet - [Phone name] Little - [Phone name]

Deploy hard

If native code (ios/android) was modified, after the PR is merged, on the master branch, upgrade the app version (+1 patch):

  • if you want an hard deployment of the testing environment, use yarn trigger:testing:deploy

Copy link
Contributor

@anoukhello anoukhello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il va falloir faire ça un peu partout dans l'app non ? J'ai le même souci sur la page Profile à la ligne 244, qui me sort la même erreur que tu mentionnes ici lingui/js-lingui#1022 (comment)

<Version>{t`Version ${Package.version}`}</Version>

@semoal
Copy link

semoal commented Apr 8, 2021

This shouldn't be required since it's already a string, just came back home, let me check it :)

@kopax-polyconseil
Copy link
Contributor Author

Close as we can use the other and more verbose synthax without this bug,

@kopax-polyconseil kopax-polyconseil deleted the tech-first-tutorial-fix branch April 23, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants