-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PC-7917) App Native - Amélioration tech - Mise à jour de lingui v2 -> v3 avec traduction au pluriel #845
Conversation
ab34bba
to
5bbaf8f
Compare
5bbaf8f
to
5e9cdab
Compare
5e9cdab
to
e19abb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge ! n'oublie pas de faire un message aux PO pour qu'ils fassent attention aux traductions.
Je pense qu'il serait même préférable de demander une repasse sur les traductions lors de la prochaine session globale de test
Y a encore quelque pétouilles, en cours de fix via lingui/js-lingui#1022 |
e19abb1
to
5ac14f4
Compare
dc8025d
to
5688a7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ne pas oublier dans la prochaine pr d'ajouter une règle eslint pour interdir les import depuis testing library
5688a7a
to
98f0426
Compare
Après ce ticket OK |
…tion au pluriel et upgrade de lingui v2 -> v3
98f0426
to
73a0038
Compare
Jira
https://passculture.atlassian.net/browse/PC-7917
Original PR
#842
Things done
test/utils.tsx
extracted a render function with a wrapper with Lingui, in this way we don't need to wrap any render function on every test, also exports every function of testing library native so you could use that file for every test_.(t)
function because it was useless, Lingui v3 is use the macro functions, there's no need to complex everything. https://lingui.js.org/ref/macro.html#examples-of-js-macros. IN some cases you need to format currencies, numbers, or dates giving a locale, Lingui also exports date, and number macros but those ones are extracted from the @lingui/core library. **I've remember this because I saw hard-written dates formatted to iso but could be good to format them using the locale instead of the iso... **lingui.config.js
with a typedef for checking that the config is valid ;)Checklist
I have:
[PC-XXX] <summary>
.