Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] Restrict MappableRegister use + Type hint improvements #499

Merged
merged 10 commits into from Apr 11, 2023
Merged

[HOTFIX] Restrict MappableRegister use + Type hint improvements #499

merged 10 commits into from Apr 11, 2023

Conversation

HGSilveri
Copy link
Collaborator

  • Temporarily blocks serialization of sequences combining MappableRegister and local operations (target, phase_shift) because the serialization of these operations requires an indexing of the qubit IDs that is incompatible with the current MappableRegister implementation (to be changed in a future release)
  • Blocks use of SLM mask with mappable registers (the SLM mask must be static like the layout)
  • Fixes bug in Sequence.switch_device() that prevented it to work with mappable registers
  • Improves type hints for device types
  • Refactors test_sequence.py to use fixtures

@HGSilveri HGSilveri requested a review from a-corni April 7, 2023 13:48
@HGSilveri HGSilveri changed the base branch from develop to master April 7, 2023 13:48
a-corni
a-corni reviewed Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just couple of comments

pulser-core/pulser/json/abstract_repr/serializer.py Show resolved Hide resolved
pulser-core/pulser/sequence/sequence.py Show resolved Hide resolved
a-corni
a-corni approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@HGSilveri HGSilveri merged commit 43ce7f8 into master Apr 11, 2023
8 checks passed
@HGSilveri HGSilveri deleted the hs/hotfix-0.11.0 branch April 11, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-corni a-corni a-corni approved these changes

@Augustinio Augustinio Awaiting requested review from Augustinio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HGSilveri @a-corni