Handle check_suite/check_run from forks #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalgn
reviewed
Aug 31, 2020
lib/api.js
Outdated
Comment on lines
122
to
132
| logger.info("Could not find branch name in this status check result"); | ||
| const foundPR = await checkPullRequestsForHeadSha( | ||
| context, | ||
| event.repository, | ||
| payload.head_sha | ||
| ); | ||
| if (!foundPR) { | ||
| logger.info( | ||
| "Could not find branch name in this status check result" + | ||
| " or corresponding PR from a forked repository" | ||
| ); | ||
| } |
There was a problem hiding this comment.
I think this logic should all be handled in checkPullRequestsForHeadSha() directly so that the handling is symmetric to the if case (line 120)
|
@michaelbeaumont I am closing this now, but only to have a better overview over active PRs! If you're still working on it, feel very free to reopen this PR! 🙏 |
|
@pascalgn I addressed all of your comments, this PR works we've been using it for weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, PRs from forks can't trigger the action because
head_branchisnullfor forks.This PR works around that by searching open PRs for the same
head_sha.See #46.