Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pull_request_target event #102

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Add support for pull_request_target event #102

merged 1 commit into from
Sep 17, 2020

Conversation

JakeChampion
Copy link
Contributor

@JakeChampion JakeChampion commented Aug 14, 2020

The pull_request_target event is useful for forks as it will use the upstream repositories workflow file and GitHub will give it a read/write access token.

More info for the event can be found in this blog post by GitHub -- https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/

The pull_request_target event is useful for forks as it will use the upstream repositories workflow file and GitHub will give it a read/write access token.
@michaelbeaumont
Copy link
Contributor

michaelbeaumont commented Aug 21, 2020

This should solve most of the problems mentioned in #46!
Although as far as I can tell, the pull_request_review event in https://github.com/pascalgn/automerge-action#usage will still be a problem for forks (i.e. we can't automerge on approval)? I suspect an approval triggering a merge is a rather rare case since usually an approval comes before the automerge label is added or a check_suite event triggers the merge. In any case, the approver can manually merge.

@pascalgn pascalgn merged commit 725a2b9 into pascalgn:master Sep 17, 2020
@pascalgn
Copy link
Owner

Thanks for the PR, it's merged now! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants